-
Notifications
You must be signed in to change notification settings - Fork 7
fix(state): unsub to subscribed context on disconnect #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c8fc5c2
to
d3593fb
Compare
It seems we can't do
because then the template will look like: <template lwc:if={!hideChild}> which is also not allowed in lwc because of
|
packages/@lwc/state/tsconfig.json
Outdated
@@ -4,7 +4,7 @@ | |||
"module": "nodeNext", | |||
"moduleResolution": "nodeNext", | |||
"esModuleInterop": false, | |||
"target": "ES2021", | |||
"target": "ES2023", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required to use non-registered symbols as WeakMap keys, more details here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted to es2021, as per our discussion
Co-authored-by: Dale Bustad <dbustad@salesforce.com>
No description provided.