feat: ensure a public property name doesn't start with an upper-case character. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trevor-bliss the new rule is not part of the valid-api because it needs to be configurable in platform. |
kevinv11n
reviewed
Sep 17, 2019
| const { docUrl } = require('../util/doc-url'); | ||
| const { isApiDecorator } = require('../util/decorator-util'); | ||
|
|
||
| const LEADING_UPPER_CASE_REGEX = new RegExp('^[A-Z.]'); |
There was a problem hiding this comment.
Why use a regex testing ascii A-Z instead of https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase to deal with all character ranges? Please verify with @caridy that this works across locales.
If you stick with a regex why is . in the regex?
There was a problem hiding this comment.
We are only interested in testing that the leading character is an upper case.
Co-Authored-By: Trevor <tbliss@salesforce.com>
…nt-plugin-lwc into apapko/no-upper-case-api
kevinv11n
approved these changes
Sep 17, 2019
trevor-bliss
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.