Skip to content

Conversation

Deekshit014
Copy link

What does this PR do?

This Pull Request resolves Issue #324 by implementing an automated workflow to publish the cloudsplaining Docker container image to Docker Hub upon every new release tag.

  • A new job, publish-docker, has been added to the existing .github/workflows/publish.yml file.
  • This job is configured to build a multi-architecture image (linux/amd64, linux/arm64) and tag it with the correct version and latest.
  • The update-brew job's dependencies were updated to explicitly wait for both publish-package (PyPI) and the new publish-docker job to ensure the entire release artifact chain is complete before the final version bump.

What gif best describes this PR or how it makes you feel?

Completion checklist

  • Additions and changes have unit tests

    N/A: No core application logic was changed; this is a CI/CD configuration update.

  • The pull request has been appropriately labeled using the provided PR labels
  • GitHub actions automation is passing (make test, make lint, make security-test, make test-js)

    Note: The final publish run will fail until secrets are added, but the syntax is correct.

  • If the UI contents or JavaScript files have been modified, generate a new example report:

    N/A: No UI or JavaScript files were touched.

# Generate the updated Javascript bundle
make build-js

# Generate the example report
make generate-report

⚠️ ACTION REQUIRED BY MAINTAINERS ⚠️

For this workflow to succeed after merging, two Repository Secrets must be created in the main repository's settings:

  1. DOCKERHUB_USERNAME
  2. DOCKERHUB_TOKEN (A Docker Hub Personal Access Token with Write permissions)

@gruebel
Copy link
Collaborator

gruebel commented Oct 9, 2025

this wouldn't work, because the docker build itself will fail, also unrelated changes included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants