Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace combineLatest deprecated usages #736

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

rafaelss95
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

When I was looking at the docs I noticed that there are some deprecated usages of combineLatest like this:

Captura de Tela 2021-08-25 às 11 02 44

Issue Number: N/A

What is the new behavior?

When I was replacing it in .mdx files, I noticed that there were some in .ts file too, so I went ahead and changed all usages from combineLatest(...) to combineLatest([...]).

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

  • There are some failing tests in libs/akita/src/__tests__/pagination.spec.ts and libs/akita/src/__tests__/persistState.spec.ts;
  • It seems like eslint and Prettier aren't happy with the current codebase. To make this commit, I had to skip it by using --no-verify, otherwise many changes would be applied. It would be good to create a separate PR to run it through the codebase and standarize this, wouldn't it?

I can help with both if it's good for you.

@NetanelBasal NetanelBasal merged commit 0a40904 into salesforce:master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants