chore(demo): fix logical issues in demo app #1051
Merged
+4
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `FormsManager` navbar link since it was deprecated in salesforce/akita@45a9d112 Add missing `remove` from cart method and remove notification part as a result of deprecating previous effects-based implementation salesforce/akita@2aaf7e351
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FormsManagernavbar link since it was deprecated in 45a9d112removefrom cart method and remove notification part as a result of deprecating previous effects-based implementation 2aaf7e351Does this PR introduce a breaking change?
Other information
While working on another PR I found that the demo app is broken. This PR fixes it.