feat: similified no-sldshook-fallback-for-lwctoken Eslint v9 #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riteshiitbbs007
added
ready-for-review
sf-nithappu
requested changes
Aug 18, 2025
Comment on lines
52
to
63
| // Parse fallback: extract text after first comma, handle nested var() | ||
| const commaMatch = rawValue.match(/,\s*(.+)\)$/); | ||
| if (!commaMatch) return; | ||
|
|
||
| const fallbackPart = commaMatch[1].trim(); | ||
|
|
||
| // Extract SLDS token from nested var() function in fallback | ||
| const sldsMatch = fallbackPart.match(/var\(([^,)]+)/); | ||
| if (!sldsMatch) return; | ||
|
|
||
| const sldsToken = sldsMatch[1]; | ||
|
|
There was a problem hiding this comment.
Use parser instead of relying on regx
sf-nithappu
added
requested-changes
…o-sldshook-fallback-for-lwctoken Eslint v9
riteshiitbbs007
added
ready-for-review
sf-nithappu
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.