Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variable name typo in getEmailInfo #10549

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from
Open

Fix variable name typo in getEmailInfo #10549

wants to merge 1 commit into from

Conversation

LoLei
Copy link

@LoLei LoLei commented Oct 9, 2024

Description

Changes the fromddr variable to fromaddr. As otherwise, this variable is not used.

Motivation and Context

Make the else branch of the getEmailInfo in User.php functional.

How To Test This

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@LoLei LoLei mentioned this pull request Oct 9, 2024
Closed
6 tasks
@serhiisamko091184 serhiisamko091184 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Branch:Hotfix PR 4-8 Score given to PRs once assessed Area:Users Issues & PRs related to all things regarding to Users labels Oct 14, 2024
@serhiisamko091184
Copy link
Contributor

Hello @LoLei,

thanks for your contribution!

Regards,
Serhii

@serhiisamko091184 serhiisamko091184 added Status: Passed Code Review Mark issue has passed code review reviewed Status: Requires Testing Requires Manual Testing and removed Status: Requires Code Review Needs the core team to code review labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiisamko091184 serhiisamko091184 serhiisamko091184 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Area:Users Issues & PRs related to all things regarding to Users Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Mark issue has passed code review reviewed Status: Requires Testing Requires Manual Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LoLei @serhiisamko091184