Skip to content

Drop billing addres from payment input #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

maarcingebala
Copy link
Member

@maarcingebala maarcingebala commented Jan 29, 2021

billingAddress in checkoutPaymentCreate mutation is deprecated and this PR removes this field from the API call. The backend uses now a billing address which is assigned to the checkout instance. If there is no billing address assigned, a validation error would be returned.

@maarcingebala maarcingebala merged commit 5f413f0 into master Feb 2, 2021
@maarcingebala maarcingebala deleted the drop-payment-billing-address-input branch February 2, 2021 11:31
piotrgrundas added a commit that referenced this pull request Mar 11, 2021
* Update gql types for storefront

* Add total count to collections

* Remove geolocalization from shop

* Drop depracted json fields and replace with proper fields (#76)

* Update types

* Update all them tests

* Drop billingAddres from payment input (#77)

* 0.3.0-5

* Add slug to ordersByUser

* Add missing slug fields

* Handle VariantAttributeScope

* Audit fix

* Fix tests

* Fix tests

* Review fixes

Co-authored-by: mmarkusik <magdalena.markusik@mirumee.com>
Co-authored-by: Marcin Gębala <5421321+maarcingebala@users.noreply.github.com>
Co-authored-by: Krzysztof Wolski <krzysztof.k.wolski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants