[Draft] 🎀 Add login on demand depending on user permission 🎀 #5176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: acc2ebf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
michalina-graczyk
changed the title
Cloud11PL
reviewed
Sep 24, 2024
| localStorage: [ | ||
| { | ||
| name: "_saleorRefreshToken", | ||
| value: loginJsonInfo.cookies[0].value, |
There was a problem hiding this comment.
Since this line of code fails very often I would check if there's an error message in loginJsonInfo and throw it before so that it's easier to debug later
michalina-graczyk
force-pushed
the
MERX-872-login-on-demand
branch
from
b20d1b7
to
cca962d
Compare
michalina-graczyk
changed the title
michalina-graczyk
force-pushed
the
MERX-872-login-on-demand
branch
from
46fa6fc
to
b43f9da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description