Voucher, Discounts, Media migrations to new macaw-ui #5158

Cloud11PL · 2024-09-12T08:56:34Z

Media tile, media upload, dropzone
Voucher details
Channel availability dialog
Category image upload
Some old discounts components
Tabs

What type of PR is this?

Usage Instructions, Screenshots, Recordings

Before	After

Have you written tests?

Yes!
No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

changeset-bot · 2024-09-12T08:56:38Z

🦋 Changeset detected

Latest commit: 0c6897a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
saleor-dashboard	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

src/collections/components/CollectionImage/CollectionImage.tsx

...components/ChannelsAvailabilityDialogChannelsList/ChannelsAvailabilityDialogChannelsList.tsx

poulch · 2024-09-16T07:53:28Z

src/components/ImageUpload/ImageUpload.tsx

+  const handleDrop = (acceptedFiles: File[]) => {
+    const fileList: FileList = {
+      ...acceptedFiles,
+      length: acceptedFiles.length,


I don't think you need that

Suggested change

length: acceptedFiles.length,

Not sure why Dashboard uses FileList but for this interface length is required

but you already spread length above ...acceptedFiles, Is it any other reason to pass it like that?

Tbh TS showed me an error and that's why I passed it explicitly. Now I checked again and you're right, it's not necessary, thanks 😅

Okay, I just tested this again, it turns out length has to be explicitly passed, otherwise it's not in the fileList object

src/components/ImageUpload/ImageUpload.tsx

src/discounts/components/DiscountCategories/DiscountCategories.tsx

src/categories/components/CategoryBackground/CategoryBackground.tsx

poulch · 2024-09-18T07:44:53Z

...components/ChannelsAvailabilityDialogChannelsList/ChannelsAvailabilityDialogChannelsList.tsx

+}) => (
+  <>
+    {channels.map((option, index) => {
+      const hasMoreChannels = index < channels.length - 1;


suggestion: Wouldn't be more clear to name it like that

Suggested change

const hasMoreChannels = index < channels.length - 1;

const isLastChannel = index === channels.length - 1;

src/components/ImageUpload/ImageUpload.tsx

src/index.css

poulch

I did small QA:

Edit icon button does not trigger any action
This input is still old, shuldn't be replace by new one?:

src/components/MediaTile/MediaTile.tsx

andrzejewsky · 2024-09-19T08:21:06Z

Quick QA:

Scroll for channel selection does not work anymore:

Not regression in this PR, but seems also like recent changes, it does look properly (label optional):
Inconsistency: we have change the modal for assigning channels (manage button), but we kept assigning products in the old version, on the same view

The migration has been tackled from the wrong side, eg. we could have migrate all selection modals first in single PR, then all media managements in another PR and finally all collection page

Cloud11PL · 2024-09-19T09:29:55Z

@andrzejewsky
Ad 1. I changed it so that that particular modal has similar height to before (note: the height will be inconsistent with other modals in that view)
Ad 2. I do not understand that comment.
Ad 3. I didn't want to do that in this PR as I was already beyond the timebox.

If I did only modal migrations then there would be still inconsistencies between the modal and eg. collection page checkboxes (because if I understand the correctly that's the issue with this PR).

github-actions · 2024-10-05T01:59:53Z

This pull request is stale because it has been open 14 days with no activity.

github-actions · 2024-10-07T02:02:28Z

This PR request has been closed because it has been stalled for 2 days with no activity. You are still welcome to reopen it and continue from where you finished. Best regards Saleor team

Cloud11PL added 5 commits September 12, 2024 10:09

Image upload

78da404

consistent ui macaw migration

fa95f8c

fix edit link

8d6a4c0

migrate image upload

528ca2a

fix types

5a7a311

github-actions bot temporarily deployed to pr-5158 September 12, 2024 09:04 Destroyed

channels availability dialog

53f2168

github-actions bot temporarily deployed to pr-5158 September 13, 2024 10:19 Destroyed

changeset

db24fc9

Cloud11PL marked this pull request as ready for review September 13, 2024 10:20

Cloud11PL requested a review from a team as a code owner September 13, 2024 10:20

Cloud11PL requested review from witoszekdev and lkostrowski September 13, 2024 10:20

github-actions bot temporarily deployed to pr-5158 September 13, 2024 10:22 Destroyed

Cloud11PL added the run pw-e2e label Sep 13, 2024

github-actions bot temporarily deployed to pr-5158 September 13, 2024 11:02 Destroyed

poulch reviewed Sep 16, 2024

View reviewed changes

Cloud11PL added 4 commits September 16, 2024 21:54

cr fixes

f11ad39

fix tests relying on channel select dialog

f65935b

fix select all channels checkbox

a8b68f4

remove unused component

5bd6e2a

Cloud11PL requested a review from a team as a code owner September 17, 2024 08:25

remove unnecessary prop

d5c1ea8

Cloud11PL requested a review from poulch September 17, 2024 08:29

json messages

605d06e

github-actions bot temporarily deployed to pr-5158 September 17, 2024 08:32 Destroyed

test fixes

761dd0c

github-actions bot temporarily deployed to pr-5158 September 17, 2024 09:32 Destroyed

voucher test fixes

eea87ce

github-actions bot temporarily deployed to pr-5158 September 17, 2024 10:13 Destroyed

github-actions bot temporarily deployed to pr-5158 September 17, 2024 10:28 Destroyed

fix expect checked state

52f55da

github-actions bot temporarily deployed to pr-5158 September 17, 2024 11:01 Destroyed

poulch reviewed Sep 18, 2024

View reviewed changes

cr fixes

bb13a21

github-actions bot temporarily deployed to pr-5158 September 18, 2024 11:22 Destroyed

Cloud11PL requested a review from poulch September 18, 2024 11:36

poulch requested changes Sep 18, 2024

View reviewed changes

src/components/MediaTile/MediaTile.tsx Outdated Show resolved Hide resolved

fixes

fc8c167

github-actions bot temporarily deployed to pr-5158 September 18, 2024 12:58 Destroyed

Cloud11PL added 4 commits September 18, 2024 15:29

add media tile test

8969271

fix radio buttons in pw test

b8c9504

fix image upload

22048d1

add comments

6902852

github-actions bot temporarily deployed to pr-5158 September 18, 2024 14:17 Destroyed

fix input for pw test

ded81ce

github-actions bot temporarily deployed to pr-5158 September 18, 2024 14:51 Destroyed

github-actions bot temporarily deployed to pr-5158 September 18, 2024 15:19 Destroyed

Cloud11PL requested a review from poulch September 19, 2024 07:54

make channel availability modal height same as before

0c6897a

github-actions bot deployed to pr-5158 September 19, 2024 09:35 View deployment

Cloud11PL marked this pull request as draft September 20, 2024 07:19

github-actions bot added the stale label Oct 5, 2024

github-actions bot closed this Oct 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Voucher, Discounts, Media migrations to new macaw-ui #5158

Voucher, Discounts, Media migrations to new macaw-ui #5158

Cloud11PL commented Sep 12, 2024 •

edited

Loading

changeset-bot bot commented Sep 12, 2024 •

edited

Loading

poulch Sep 16, 2024

Cloud11PL Sep 16, 2024

poulch Sep 16, 2024

Cloud11PL Sep 17, 2024

Cloud11PL Sep 18, 2024

poulch Sep 18, 2024

poulch left a comment

andrzejewsky commented Sep 19, 2024 •

edited

Loading

Cloud11PL commented Sep 19, 2024

github-actions bot commented Oct 5, 2024

github-actions bot commented Oct 7, 2024

	const hasMoreChannels = index < channels.length - 1;
	const isLastChannel = index === channels.length - 1;

Voucher, Discounts, Media migrations to new macaw-ui #5158

Voucher, Discounts, Media migrations to new macaw-ui #5158

Conversation

Cloud11PL commented Sep 12, 2024 • edited Loading

What type of PR is this?

Related Issues or Documents

Usage Instructions, Screenshots, Recordings

Have you written tests?

[Optional] Description

changeset-bot bot commented Sep 12, 2024 • edited Loading

🦋 Changeset detected

poulch Sep 16, 2024

Choose a reason for hiding this comment

Cloud11PL Sep 16, 2024

Choose a reason for hiding this comment

poulch Sep 16, 2024

Choose a reason for hiding this comment

Cloud11PL Sep 17, 2024

Choose a reason for hiding this comment

Cloud11PL Sep 18, 2024

Choose a reason for hiding this comment

poulch Sep 18, 2024

Choose a reason for hiding this comment

poulch left a comment

Choose a reason for hiding this comment

andrzejewsky commented Sep 19, 2024 • edited Loading

Cloud11PL commented Sep 19, 2024

github-actions bot commented Oct 5, 2024

github-actions bot commented Oct 7, 2024

Cloud11PL commented Sep 12, 2024 •

edited

Loading

changeset-bot bot commented Sep 12, 2024 •

edited

Loading

andrzejewsky commented Sep 19, 2024 •

edited

Loading