Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback data length to 0 on product dialog #2485

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

krzysztofzuraw
Copy link
Member

@krzysztofzuraw krzysztofzuraw commented Oct 27, 2022

Fixes #2482. After reload user sees the open dialog - the same behaviour as in other parts of dashboard.

Screenshots

Before fix - screenshot taken from #2482

After fix

CleanShot.2022-10-27.at.10.58.37.mp4

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes [data-test-id] are added for new elements
  4. Changes are mentioned in the changelog
  5. The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
MARKETPLACE_URL=https://apps.saleor.io
SALEOR_APPS_ENDPOINT=https://apps.saleor.io/api/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. giftCard
  3. category
  4. collection
  5. attribute
  6. productType
  7. shipping
  8. customer
  9. permissions
  10. menuNavigation
  11. pages
  12. sales
  13. vouchers
  14. homePage
  15. login
  16. orders
  17. products
  18. app
  19. plugins
  20. translations
  21. navigation
  22. variants

CONTAINERS=1

@github-actions github-actions bot temporarily deployed to 2482-assign-product-dialog-error October 27, 2022 08:55 Inactive
@krzysztofzuraw krzysztofzuraw marked this pull request as ready for review October 27, 2022 09:13
@krzysztofzuraw krzysztofzuraw requested review from a team, andrzejewsky, orzechdev and szczecha and removed request for a team October 27, 2022 09:13
@krzysztofzuraw krzysztofzuraw changed the title fix: fallback data length to 0 on product dialog Fallback data length to 0 on product dialog Oct 31, 2022
@krzysztofzuraw krzysztofzuraw merged commit da8e4e5 into main Oct 31, 2022
@krzysztofzuraw krzysztofzuraw deleted the 2482-assign-product-dialog-error branch October 31, 2022 10:39
@krzysztofzuraw krzysztofzuraw mentioned this pull request Nov 18, 2022
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected error when editing a collection when refreshing the page after opening the assigned product dialog
4 participants