DataGrid full-screen mode #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzejewsky
requested review from
a team,
krzysztofzuraw and
Droniu
and removed request for
a team
github-actions
bot
temporarily deployed
to
2412-full-screen-data-grid
github-actions
bot
temporarily deployed
to
storybook 2412-full-screen-data-grid
andrzejewsky
commented
Oct 24, 2022
| className?: string; | ||
| } | ||
|
|
||
| const Portal = ({ className, children, open }) => { |
There was a problem hiding this comment.
this file implements actually a modal with mounting/unmounting, will leave a comment here to make it more generic so we can apply it across all of our modals
Droniu
previously approved these changes
Oct 26, 2022
github-actions
bot
temporarily deployed
to
2412-full-screen-data-grid
github-actions
bot
temporarily deployed
to
storybook 2412-full-screen-data-grid
krzysztofzuraw
previously approved these changes
Oct 26, 2022
github-actions
bot
temporarily deployed
to
2412-full-screen-data-grid
github-actions
bot
temporarily deployed
to
storybook 2412-full-screen-data-grid
Droniu
previously approved these changes
Oct 27, 2022
github-actions
bot
temporarily deployed
to
2412-full-screen-data-grid
Droniu
approved these changes
Oct 27, 2022
orzechdev
approved these changes
Oct 27, 2022
Droniu
pushed a commit
that referenced
this pull request
Nov 3, 2022
* full screen mode * add product title, review * update snapshots * Update messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2412
Screenshots
Pull Request Checklist
[data-test-id]are added for new elementsTest environment config
API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
MARKETPLACE_URL=https://apps.saleor.io
SALEOR_APPS_ENDPOINT=https://apps.saleor.io/api/saleor-apps
Do you want to run more stable tests?
To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.
CONTAINERS=1