Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable spellcheck for PII fields #2416

Merged
merged 5 commits into from
Oct 31, 2022
Merged

Disable spellcheck for PII fields #2416

merged 5 commits into from
Oct 31, 2022

Conversation

krzysztofzuraw
Copy link
Member

@krzysztofzuraw krzysztofzuraw commented Oct 19, 2022 •
edited
Loading

I disabled spellcheck for personal information fields:

  • firstName
  • lastName
  • all of address fields
  • passwords

Fixes #2413

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes [data-test-id] are added for new elements
  4. Changes are mentioned in the changelog
  5. The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
MARKETPLACE_URL=https://marketplace-gray.vercel.app/

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. giftCard
  3. category
  4. collection
  5. attribute
  6. productType
  7. shipping
  8. customer
  9. permissions
  10. menuNavigation
  11. pages
  12. sales
  13. vouchers
  14. homePage
  15. login
  16. orders
  17. products
  18. app
  19. plugins
  20. translations
  21. navigation

CONTAINERS=1

@github-actions github-actions bot temporarily deployed to 2413-disable-spellcheck-pii October 19, 2022 13:35 Inactive
@github-actions github-actions bot temporarily deployed to storybook 2413-disable-spellcheck-pii October 19, 2022 13:35 Inactive
@krzysztofzuraw krzysztofzuraw marked this pull request as ready for review October 19, 2022 13:38
@krzysztofzuraw krzysztofzuraw requested review from a team, andrzejewsky and Droniu and removed request for a team October 19, 2022 13:39
Droniu
Droniu previously approved these changes Oct 19, 2022
View reviewed changes
@github-actions github-actions bot temporarily deployed to 2413-disable-spellcheck-pii October 20, 2022 06:43 Inactive
@github-actions github-actions bot temporarily deployed to storybook 2413-disable-spellcheck-pii October 20, 2022 06:43 Inactive
andrzejewsky
andrzejewsky previously approved these changes Oct 20, 2022
View reviewed changes
@github-actions github-actions bot temporarily deployed to 2413-disable-spellcheck-pii October 20, 2022 09:56 Inactive
@github-actions github-actions bot temporarily deployed to storybook 2413-disable-spellcheck-pii October 20, 2022 09:56 Inactive
eCzerniak
eCzerniak suggested changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@eCzerniak eCzerniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing:

  • warehouses address,
  • draftOrder add client new address,
  • siteSettings,

@github-actions github-actions bot temporarily deployed to 2413-disable-spellcheck-pii October 20, 2022 13:40 Inactive
@github-actions github-actions bot temporarily deployed to storybook 2413-disable-spellcheck-pii October 20, 2022 13:40 Inactive
andrzejewsky
andrzejewsky previously approved these changes Oct 21, 2022
View reviewed changes
@github-actions github-actions bot temporarily deployed to 2413-disable-spellcheck-pii October 21, 2022 10:15 Inactive
@github-actions github-actions bot temporarily deployed to storybook 2413-disable-spellcheck-pii October 21, 2022 10:15 Inactive
@krzysztofzuraw krzysztofzuraw changed the title feat: disable spellcheck for PII fields Disable spellcheck for PII fields Oct 21, 2022
Droniu
Droniu previously approved these changes Oct 21, 2022
View reviewed changes
@github-actions github-actions bot temporarily deployed to 2413-disable-spellcheck-pii October 24, 2022 07:32 Inactive
@github-actions github-actions bot temporarily deployed to storybook 2413-disable-spellcheck-pii October 24, 2022 07:32 Inactive
eCzerniak
eCzerniak previously approved these changes Oct 24, 2022
View reviewed changes
andrzejewsky
andrzejewsky previously approved these changes Oct 24, 2022
View reviewed changes
Droniu
Droniu previously approved these changes Oct 24, 2022
View reviewed changes
@github-actions github-actions bot temporarily deployed to 2413-disable-spellcheck-pii October 26, 2022 10:40 Inactive
@krzysztofzuraw krzysztofzuraw merged commit cac3e43 into main Oct 31, 2022
@krzysztofzuraw krzysztofzuraw deleted the 2413-disable-spellcheck-pii branch October 31, 2022 10:37
Droniu pushed a commit that referenced this pull request Nov 3, 2022
@krzysztofzuraw @Droniu
Disable spellcheck for PII fields (#2416)
47ba851
Droniu pushed a commit that referenced this pull request Nov 3, 2022
@krzysztofzuraw @Droniu
Disable spellcheck for PII fields (#2416)
bb78e5f
@krzysztofzuraw krzysztofzuraw mentioned this pull request Nov 18, 2022
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrzejewsky andrzejewsky andrzejewsky approved these changes

@eCzerniak eCzerniak eCzerniak approved these changes

@Droniu Droniu Droniu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable spellchecker on PII and password fields
4 participants
@krzysztofzuraw @andrzejewsky @eCzerniak @Droniu