Use single price value instead of range in product list #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: SALEOR-7906 Use single price value instead of range |
github-actions
bot
temporarily deployed
to
saleor-7906-use-single-price-value
github-actions
bot
temporarily deployed
to
storybook saleor-7906-use-single-price-value
Droniu
requested review from
a team,
andrzejewsky and
orzechdev
and removed request for
a team
|
Could we improve it further by using formatRangeIntl.NumberFormat("en-US", {style: "currency", currency: "USD"}).formatRange("1.00", "21.00");
// "$1.00 – $21.00"
Intl.NumberFormat("pl-PL", {style: "currency", currency: "USD"}).formatRange("1.00", "21.00");
// "1,00–21,00 USD"formatIntl.NumberFormat("en-US", {style: "currency", currency: "USD"}).format("123.00");
// "$123.00"
Intl.NumberFormat("pl-PL", {style: "currency", currency: "USD"}).format("123.00");
// "123,00 USD" |
github-actions
bot
temporarily deployed
to
saleor-7906-use-single-price-value
github-actions
bot
temporarily deployed
to
storybook saleor-7906-use-single-price-value
github-actions
bot
temporarily deployed
to
saleor-7906-use-single-price-value
orzechdev
approved these changes
Oct 27, 2022
andrzejewsky
approved these changes
Oct 28, 2022
Comment on lines
+18
to
+47
| if (from && to) { | ||
| return from.amount === to.amount | ||
| ? formatMoney(from, locale) | ||
| : formatMoneyRange(from, to, locale); | ||
| } | ||
| if (from && !to) { | ||
| return intl.formatMessage( | ||
| { | ||
| id: "lW5uJO", | ||
| defaultMessage: "from {money}", | ||
| description: "money", | ||
| }, | ||
| { | ||
| money: formatMoney(from, locale), | ||
| }, | ||
| ); | ||
| } | ||
| if (!from && to) { | ||
| return intl.formatMessage( | ||
| { | ||
| id: "hptDxW", | ||
| defaultMessage: "to {money}", | ||
| description: "money", | ||
| }, | ||
| { | ||
| money: formatMoney(to, locale), | ||
| }, | ||
| ); | ||
| } | ||
| return "-"; |
There was a problem hiding this comment.
if that is a component, perhaps a format component would be more reasonable here?
szczecha
approved these changes
Nov 2, 2022
Droniu
added a commit
that referenced
this pull request
Nov 3, 2022
* Render single value when amount of money is matching * Use Intl.NumberFormat in money formatting * Extract messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it improves product list view. With channel filter selected, we often see price ranges for single-variant products even though the price is constant. This change improves the readability by rendering single price whenever the range is not actually a range.
PR intended to be tested with API branch: main
Screenshots
Before
After
Pull Request Checklist
[data-test-id]are added for new elementsTest environment config
API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
MARKETPLACE_URL=https://marketplace-gray.vercel.app/
Do you want to run more stable tests?
To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.
CONTAINERS=1