Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hover from non-interactive table rows #2358

Merged
merged 4 commits into from
Oct 27, 2022
Merged

Remove hover from non-interactive table rows #2358

merged 4 commits into from
Oct 27, 2022

Conversation

witoszekdev
Copy link
Member

@witoszekdev witoszekdev commented Oct 6, 2022 •
edited
Loading

I want to merge this change because it removes hover effect for TableRow which are not interactive (no href or onClick props)

PR intended to be tested with API branch:

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes [data-test-id] are added for new elements
  4. Changes are mentioned in the changelog
  5. The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
MARKETPLACE_URL=https://marketplace-gray.vercel.app/

Do you want to run more stable tests?

Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. giftCard
  3. category
  4. collection
  5. attribute
  6. productType
  7. shipping
  8. customer
  9. permissions
  10. menuNavigation
  11. pages
  12. sales
  13. vouchers
  14. homePage
  15. login
  16. orders
  17. products
  18. app
  19. plugins
  20. translations
  21. navigation

CONTAINERS=1

@github-actions github-actions bot temporarily deployed to remove-hover-table October 6, 2022 17:16 Inactive
@github-actions github-actions bot temporarily deployed to storybook remove-hover-table October 6, 2022 17:16 Inactive
@github-actions github-actions bot temporarily deployed to remove-hover-table October 6, 2022 17:36 Inactive
@github-actions github-actions bot temporarily deployed to storybook remove-hover-table October 6, 2022 17:36 Inactive
@witoszekdev witoszekdev requested review from a team, krzysztofzuraw and orzechdev and removed request for a team October 7, 2022 08:20
orzechdev
orzechdev previously approved these changes Oct 10, 2022
View reviewed changes
@witoszekdev witoszekdev requested review from andrzejewsky and removed request for krzysztofzuraw October 26, 2022 10:47
andrzejewsky
andrzejewsky previously approved these changes Oct 26, 2022
View reviewed changes
@github-actions github-actions bot temporarily deployed to remove-hover-table October 26, 2022 11:58 Inactive
@witoszekdev witoszekdev enabled auto-merge (squash) October 26, 2022 12:08
@witoszekdev witoszekdev merged commit 11a990d into main Oct 27, 2022
@witoszekdev witoszekdev deleted the remove-hover-table branch October 27, 2022 10:58
Droniu pushed a commit that referenced this pull request Nov 3, 2022
@witoszekdev @Droniu
Remove hover from non-interactive table rows (#2358)
ba79d5e 
* Disable hover effect when TableRow is not clickable

* Replace TableRow with TableRowLink

* Update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orzechdev orzechdev orzechdev approved these changes

@andrzejewsky andrzejewsky andrzejewsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@witoszekdev @andrzejewsky @orzechdev