Named months #2130
Merged
Named months #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orzechdev
approved these changes
Jul 1, 2022
dominik-zeglen
approved these changes
Jul 1, 2022
Droniu
approved these changes
Jul 1, 2022
|
Task linked: SALEOR-7537 Change to named months |
dominik-zeglen
pushed a commit
that referenced
this pull request
Aug 1, 2022
* Use named moths to avoid ambiguity * Change format of gift card expiration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use named months to avoid ambiguous dates
01/02/2022can mean Jan or Feb things depending on your locale.Components affected:
PageDetailsPage
GiftCardUpdateInfoCardContent
VisibilityCard
ChannelsAvailabilityCard
ChannelAvailabilityItemContent