Add b3 text map extractor #23
Conversation
lib/jaeger/extractors.rb
Outdated
|
|
||
| class B3CodecCommon | ||
| def self.extract(carrier, keys) | ||
| trace_id = TraceId.base16_hex_id_to_uint64(carrier[keys[0]]) |
There was a problem hiding this comment.
keys[0] etc are hard to understand. Rather create a map instead of an array and do something like keys::TRACE_ID
There was a problem hiding this comment.
made the keys into a class with constants
|
It works fine between languages, like from Go to Ruby, when the received request is usually through Rack. But something like AWS Lambdas do not necessarily have to get request headers through Rack, so I thought it might be useful to have a plain text map extractor. |
|
One more request: please add specs for the new extractor. You can basically copy https://github.com/salemove/jaeger-client-ruby/blob/299ad0bc4ec355aa71d3031c8db7437e7b012991/spec/jaeger/extractors/b3_rack_codec_spec.rb and change keys and descriptions. |
|
Thanks! |
There was no extractor for B3TextMapCodec when requests do not come in through Rack. The particular case I ran into was with AWS Lambdas in Ruby, which may be a pretty common use case.
Please let me know what you think