Skip to content
This repository has been archived by the owner on Jan 16, 2025. It is now read-only.

Commit

Permalink
Rename AsyncReporter to RemoteReporter
Browse files Browse the repository at this point in the history
This is more inline with other jaeger clients.
  • Loading branch information
indrekj committed Dec 25, 2018
1 parent c81e0ce commit cd168f4
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 16 deletions.
2 changes: 1 addition & 1 deletion lib/jaeger/client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def self.build(host: '127.0.0.1',
sender = UdpSender.new(host: host, port: port, encoder: encoder, logger: logger)
end

reporter = Reporters::AsyncReporter.create(sender: sender, flush_interval: flush_interval)
reporter = Reporters::RemoteReporter.new(sender: sender, flush_interval: flush_interval)

Tracer.new(
reporter: reporter,
Expand Down
2 changes: 1 addition & 1 deletion lib/jaeger/client/reporters.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# frozen_string_literal: true

require_relative 'reporters/async_reporter'
require_relative 'reporters/composite_reporter'
require_relative 'reporters/in_memory_reporter'
require_relative 'reporters/logging_reporter'
require_relative 'reporters/null_reporter'
require_relative 'reporters/remote_reporter'
Original file line number Diff line number Diff line change
@@ -1,16 +1,12 @@
# frozen_string_literal: true

require_relative './async_reporter/buffer'
require_relative './remote_reporter/buffer'

module Jaeger
module Client
module Reporters
class AsyncReporter
def self.create(sender:, flush_interval:)
new(sender, flush_interval)
end

def initialize(sender, flush_interval)
class RemoteReporter
def initialize(sender:, flush_interval:)
@sender = sender
@flush_interval = flush_interval
@buffer = Buffer.new
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
module Jaeger
module Client
module Reporters
class AsyncReporter
class RemoteReporter
class Buffer
def initialize
@buffer = []
Expand Down
2 changes: 1 addition & 1 deletion spec/jaeger/client/injectors/jaeger_rack_codec_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
describe Jaeger::Client::Injectors::JaegerRackCodec do
let(:tracer) do
Jaeger::Client::Tracer.new(
reporter: instance_spy(Jaeger::Client::Reporters::AsyncReporter),
reporter: instance_spy(Jaeger::Client::Reporters::RemoteReporter),
sampler: Jaeger::Client::Samplers::Const.new(true),
injectors: Jaeger::Client::Injectors.prepare({}),
extractors: Jaeger::Client::Extractors.prepare({})
Expand Down
2 changes: 1 addition & 1 deletion spec/jaeger/client/injectors/jaeger_text_map_codec_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
describe Jaeger::Client::Injectors::JaegerTextMapCodec do
let(:tracer) do
Jaeger::Client::Tracer.new(
reporter: instance_spy(Jaeger::Client::Reporters::AsyncReporter),
reporter: instance_spy(Jaeger::Client::Reporters::RemoteReporter),
sampler: Jaeger::Client::Samplers::Const.new(true),
injectors: Jaeger::Client::Injectors.prepare({}),
extractors: Jaeger::Client::Extractors.prepare({})
Expand Down
2 changes: 1 addition & 1 deletion spec/jaeger/client/reporters/composite_reporter_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
RSpec.describe Jaeger::Client::Reporters::CompositeReporter do
let(:reporter) { described_class.new(reporters: [reporter1, reporter2]) }
let(:reporter1) { instance_spy(Jaeger::Client::Reporters::InMemoryReporter) }
let(:reporter2) { instance_spy(Jaeger::Client::Reporters::AsyncReporter) }
let(:reporter2) { instance_spy(Jaeger::Client::Reporters::RemoteReporter) }

describe '#report' do
it 'forwards span to all reporters' do
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require 'spec_helper'

RSpec.describe Jaeger::Client::Reporters::AsyncReporter do
let(:reporter) { described_class.new(sender, 1) }
RSpec.describe Jaeger::Client::Reporters::RemoteReporter do
let(:reporter) { described_class.new(sender: sender, flush_interval: 1) }
let(:sender) { spy }
let(:operation_name) { 'op-name' }

Expand Down
2 changes: 1 addition & 1 deletion spec/jaeger/client/tracer_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
extractors: Jaeger::Client::Extractors.prepare(extractors)
)
end
let(:reporter) { instance_spy(Jaeger::Client::Reporters::AsyncReporter) }
let(:reporter) { instance_spy(Jaeger::Client::Reporters::RemoteReporter) }
let(:sampler) { Jaeger::Client::Samplers::Const.new(true) }
let(:injectors) { {} }
let(:extractors) { {} }
Expand Down

0 comments on commit cd168f4

Please sign in to comment.