Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules from subscriptions won't match URL contains port #304

Closed
uenokatsura opened this issue Jul 16, 2023 · 17 comments
Closed

Rules from subscriptions won't match URL contains port #304

uenokatsura opened this issue Jul 16, 2023 · 17 comments
Labels
type-bug Bug in code or behaviour

Comments

@uenokatsura
Copy link

Description

[AutoProxy 0.1.0]

||douyu.com

won't match wss://wsproxy.douyu.com:6675/

Steps to Reproduce

  1. Subcribe to a ruleset.
  2. Visit any site in the rule that will connect to non-standard port.
  3. Check Proxyable Resources

Which browsers did you test this on?

Chrome

Affected browser versions

Chrome 114

Affected SmartProxy versions

SmarProxy 1.2.0

Screenshots of the problems or steps to reproduce

No response

Any additional context

I find #238 in the issues.
The same thing happens to DomainSubdomain though I can change to Host regex there.
You can't do that with Rules Subscriptions

@uenokatsura uenokatsura added the type-bug Bug in code or behaviour label Jul 16, 2023
@salarcode
Copy link
Owner

2. Visit any site in the rule that will connect to non-standard port.

Can you provide such list here?

@uenokatsura
Copy link
Author

uenokatsura commented Jul 16, 2023

2. Visit any site in the rule that will connect to non-standard port.

Can you provide such list here?

My Rule and an example douyu live streaming.
Btw, SmartProxy will stop responding if too many requests on Proxyable Resources page.

@salarcode
Copy link
Owner

salarcode commented Jul 16, 2023

these rules you mean?

# Douyu 斗鱼
||douyu.com
||douyu.tv
||douyuscdn.com
||douyutv.com
||edgesrv.com

These are defined for default port 80 and 443 because port is not mentioned in them.
Custom ports must be defined in the rules otherwise default port will be used.
Like this

||douyu.com:6675

More info: https://github.com/gfwlist/gfwlist/wiki/Syntax

@salarcode
Copy link
Owner

Btw, SmartProxy will stop responding if too many requests on Proxyable Resources page.

That is because of the table plugin, nothing I can do about it, clean the table constantly to keep the flow going

@uenokatsura
Copy link
Author

Btw, SmartProxy will stop responding if too many requests on Proxyable Resources page.

That is because of the table plugin, nothing I can do about it, clean the table constantly to keep the flow going

But both gfwlist syntax and ABP filters mentions no port, I believe ALL Port should be included even not announced with the single rule of ||douyu.com.
And that's ABP, Adguard and SwitchyOmega's default behavior.

@salarcode
Copy link
Owner

The implementation of SwitchyOmega rules and AutoProxy rules are imported from their libraries so we have currently what they have ! Same logic

@uenokatsura
Copy link
Author

uenokatsura commented Jul 16, 2023

The implementation of SwitchyOmega rules and AutoProxy rules are imported from their libraries so we have currently what they have ! Same logic

With SwitchyOmega
image

With SmarProxy
image

It doesn't seems SwitchyOmega and SmarProxy have the same behavior here.

@salarcode
Copy link
Owner

I have not written the rules parser code, so it must some misunderstanding between deployments!

SwitchyOmega is not working in Chrome anymore, are you using something custom ?

@uenokatsura
Copy link
Author

SwitchyOmega is not working in Chrome anymore, are you using something custom ?

No, I'm on official Google Chrome v114.0.5735.199.

@salarcode
Copy link
Owner

salarcode commented Jul 16, 2023

I found that this issue is caused by the fix for #298 I'm putting a release to patch this.

Thanks for the report

@salarcode
Copy link
Owner

salarcode commented Jul 16, 2023

SwitchyOmega is not working in Chrome anymore, are you using something custom ?

No, I'm on official Google Chrome v114.0.5735.199.

I mean are you using custom version of SwitchyOmega? it is not working for me

@uenokatsura
Copy link
Author

I mean are you using custom version of SwitchyOmega? it is not working for me

I think I'm using the official one.

@salarcode
Copy link
Owner

Verion 1.2.1 is release to Chrome, you can check if it is working fine.

@uenokatsura
Copy link
Author

Verion 1.2.1 is release to Chrome, you can check if it is working fine.

image 😿

@E021ntox
Copy link

E021ntox commented Jul 17, 2023

Same issue. 1.2.1 is still not working.

@salarcode
Copy link
Owner

salarcode commented Jul 17, 2023

The issue is fixed, but the fix is not applied to Proxyable Resources page, in Chrome browsers this page can't use same engine as the Proxy engine. Its browser limitations.
Use Firefox, SmartProxy has more features there and don't have these limitations.

@uenokatsura
Copy link
Author

The issue is fixed, but the fix is not applied to Proxyable Resources page, in Chrome browsers this page can't use same engine as the Proxy engine. Its browser limitations.

Confirmed from my proxy log that all port related issues on rule seem to have been fixed.
Thanks.
👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Bug in code or behaviour
Projects
None yet
Development

No branches or pull requests

3 participants