Fix GeoSearch elink using retmode xml #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah wow, that's a lot of flake8 violations. |
|
Happy to address them, but not sure if you have your own opinions about these rules. Furthermore, a tool like |
|
Thanks for your PR and contributions! Easisest way to fix the flake8 issues is to run |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #200 +/- ##
===========================================
- Coverage 59.53% 58.63% -0.90%
===========================================
Files 8 8
Lines 1893 1893
===========================================
- Hits 1127 1110 -17
- Misses 766 783 +17
☔ View full report in Codecov by Sentry. |
|
Thanks so much for merging and publishing the PRs! If you're looking for more contributions let me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_geo_search_1was failing on all branches. The eLink request withinGeoSearch.search()seemed to return an empty body despite receiving status code 200 and healthy response headers. Changing'retmode': 'xml'seems to generate the desired output.The test seems to take a long time to run. I tested the code I changed to make sure it wasn't the cause. I'm not sure whether this performance differs from calls made in the past.
It may be worth reaching out to NCBI to understand why
the request with 'retmode': 'json'stopped working.This should unblock #198 #199 and any future PRs