SAK-51055 Samigo cc+ import issues with embedded image in CKEditor #13423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ottenhoff
approved these changes
Mar 8, 2025
|
@stetsche Since this touched your work on performance improvement on Samigo site copy - I think it needs a review from you. |
stetsche
reviewed
Mar 10, 2025
There was a problem hiding this comment.
@csev , thanks for the improvements! I left a few comments regarding some context and your changes. Do you think we should do another iteration of performance testing with the added code, or do you think it's really light additions?
CC: @bgarciaentornos
.../src/java/org/sakaiproject/tool/assessment/services/assessment/AssessmentEntityProducer.java
Show resolved
Hide resolved
.../src/java/org/sakaiproject/tool/assessment/services/assessment/AssessmentEntityProducer.java
Outdated
Show resolved
Hide resolved
.../src/java/org/sakaiproject/tool/assessment/services/assessment/AssessmentEntityProducer.java
Outdated
Show resolved
Hide resolved
stetsche
reviewed
Mar 11, 2025
.../src/java/org/sakaiproject/tool/assessment/services/assessment/AssessmentEntityProducer.java
Outdated
Show resolved
Hide resolved
.../src/java/org/sakaiproject/tool/assessment/services/assessment/AssessmentEntityProducer.java
Outdated
Show resolved
Hide resolved
ern
changed the title
|
@stetsche I do think that a quick test of the performance fixes is in order. I do not think that my changes change it in any material way. I think that the test is more to insure no regressions. cc: @bgarciaentornos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three steps to this change - they are separate commits below:
To do this, I extended the calling sequences for internal methods for updateEntityReferences() and migrateText() so they can handle the "Import from Site" or "merge()" use cases. The method signatures got a little long but I really wanted to avoid duplicating the complex code that goes through and finds all the RTE areas post copy or post merge. It seemed more reliable in the long run the have a few more parameters and if tests that a lot of intricate code duplicated.
@stetsche Since this touched your work on performance improvement on Samigo site copy - I think it needs a review from you.
Comments welcome.