Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAK-49146 Common switch TypeImpl to nonstrict-read-write cache strategy and atomic #11803

Merged
merged 3 commits into from
Jun 3, 2024
Merged

SAK-49146 Common switch TypeImpl to nonstrict-read-write cache strategy and atomic #11803

merged 3 commits into from
Jun 3, 2024

Conversation

jesusmmp
Copy link
Contributor

@jesusmmp jesusmmp commented Aug 2, 2023 •
edited
Loading

https://sakaiproject.atlassian.net/browse/SAK-49146

Pending work. We were talking about this problem some months ago :)

@jesusmmp jesusmmp requested a review from ern August 2, 2023 08:43
ern
ern approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@ern ern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be db changes needed to drop the version in SAKAI_PERSON_T

Trying to remember if there were other changes needed?

@jesusmmp
Copy link
Contributor Author

jesusmmp commented Aug 4, 2023

There will be db changes needed to drop the version in SAKAI_PERSON_T

Trying to remember if there were other changes needed?

We talked about not drop the version in SAKAI_PERSON_T

Other changes were done here: https://github.com/sakaiproject/sakai/pull/11267/files

@ern
Copy link
Contributor

ern commented Aug 9, 2023

if you remove the optimistic lock then version column is useless and should be removed.

ern
ern requested changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@ern ern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets discuss this one in the next Core call

@ern ern changed the title SAK-49146 Ignite: Error Cache pesimistic and node fails - TypeImpl SAK-49146 Common Error Cache pesimistic and node fails - TypeImpl Jun 3, 2024
@ern ern changed the title SAK-49146 Common Error Cache pesimistic and node fails - TypeImpl SAK-49146 Common switch TypeImpl to nonstrict-read-write cache strategy and atomic Jun 3, 2024
@ern ern merged commit 7aef2d9 into sakaiproject:master Jun 3, 2024
5 checks passed
ern pushed a commit that referenced this pull request Oct 2, 2024
@jesusmmp @ern
SAK-49146 Common switch TypeImpl to nonstrict-read-write cache strate…
467d891 
…gy and atomic (#11803)

Co-authored-by: Earle Nietzel <earle@longsight.com>
(cherry picked from commit 7aef2d9)
ern pushed a commit that referenced this pull request Oct 2, 2024
@jesusmmp @ern
SAK-49146 Common switch TypeImpl to nonstrict-read-write cache strate…
9c997e8 
…gy and atomic (#11803)

Co-authored-by: Earle Nietzel <earle@longsight.com>
(cherry picked from commit 7aef2d9)
ottenhoff added a commit to LongsightGroup/sakai that referenced this pull request Oct 29, 2024
@ottenhoff
Revert "SAK-49146 Common switch TypeImpl to nonstrict-read-write cach…
214fb2a 
…e strategy and atomic (sakaiproject#11803)"

This reverts commit 9c997e8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ern ern ern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesusmmp @ern