bitbang-hal updates #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPI mode is defined by CPOL and CPHA parameters, where CPOL determines the polarity of the clock and CPHA determines the timing of the data bits relative to the clock pulses. Constants for all four SPI modes are defined in embedded_hal. Re-export them from bitbang_hal to simplify its usage: now there is no no need to pull embedded_hal as dependency just to use MODE_* consts. Besides, update spi example accordingly. Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
Enable both LSB first and MSB first transfers: add function set_bit_order to select configuration. By default MSB first configuration is used. Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
Use 'match' for different SPI modes to improve readability. Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sajattack and all,
Here is a patch series with misc updates for bitbang-hal.
Functional changes include:
Other changes include:
Besides, spi example is updated according to suggested changes.
Regards,
Sergey