fix: ReactDom.creatRoot().render() is not valid

saitoChen · Nov 8, 2023 · 44429fa · 44429fa
1 parent 06f81de
commit 44429fa
Show file tree

Hide file tree

Showing 5 changed files with 167 additions and 6 deletions.
diff --git a/dist/node_modules/react-dom/client.js b/dist/node_modules/react-dom/client.js
diff --git a/dist/node_modules/react-dom/index.js b/dist/node_modules/react-dom/index.js
diff --git a/packages/react-reconciler/src/fiber.ts b/packages/react-reconciler/src/fiber.ts
@@ -75,7 +75,6 @@ export const crateWorkInProgress = (
 	if (wip === null) {
 		// mount
 		wip = new FiberNode(current.tag, pendingProps, current.key)
-		wip.type = current.type
 		wip.stateNode = current.stateNode
 
 		wip.alternate = current

diff --git a/packages/react-reconciler/src/updateQueue.ts b/packages/react-reconciler/src/updateQueue.ts
@@ -49,7 +49,7 @@ export const processUpdateQueue = <State>(
 		if (typeof action === 'function') {
 			result.memorizedState = (action as (prevState: State) => State)(baseState)
 		} else {
-			result.memorizedState = baseState
+			result.memorizedState = action
 		}
 	}
 

diff --git a/packages/react-reconciler/src/workLoop.ts b/packages/react-reconciler/src/workLoop.ts
@@ -8,6 +8,7 @@ import { beginWork } from './beginWork'
 import { completeWork } from './completeWork'
 import { HostRoot } from './workTags'
 import { MutationMask, NoFlags } from './fiberFlags'
+import { commitMutationEffects } from './commitWork'
 
 let workInProgress: FiberNode | null = null
 
@@ -76,6 +77,7 @@ const commitRoot = (root: FiberRootNode) => {
 
 		// switch fiber tree
 		// hostRootNode
+		commitMutationEffects(finishedWork)
 		root.current = finishedWork
 		// layout
 	} else {