Skip to content

Update Python SDK to handle xml response types #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyler-mairose-sp merged 1 commit into from
Feb 6, 2025
Merged

Update Python SDK to handle xml response types #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ pydantic >= 2
aenum >= 3.1.11
mypy>=1.4.1
types-python-dateutil>=2.8.19
xmltodict>=0.14.2
3 changes: 3 additions & 0 deletions sailpoint/beta/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import os
import re
import tempfile
import xmltodict

from urllib.parse import quote
from typing import Tuple, Optional, List, Dict, Union
Expand Down Expand Up @@ -427,6 +428,8 @@ def deserialize(self, response_text: str, response_type: str, content_type: Opti
data = ""
else:
data = json.loads(response_text)
elif content_type.startswith("application/xml") or content_type.startswith("text/xml"):
data = xmltodict.parse(response_text)
elif content_type.startswith("text/plain"):
data = response_text
else:
Expand Down
2 changes: 1 addition & 1 deletion sailpoint/beta/test/test_account_usage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def make_instance(self, include_optional) -> AccountUsage:
model = AccountUsage()
if include_optional:
return AccountUsage(
var_date = 'Fri Apr 21 00:00:00 UTC 2023',
var_date = 'Thu Apr 20 20:00:00 EDT 2023',
count = 10
)
else:
Expand Down
4 changes: 2 additions & 2 deletions sailpoint/beta/test/test_non_employee_request_without_approval_item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ def make_instance(self, include_optional) -> NonEmployeeRequestWithoutApprovalIt
approval_status = 'APPROVED',
comment = 'approved',
completion_date = '2020-03-24T11:11:41.139-05:00',
start_date = 'Tue Mar 24 00:00:00 UTC 2020',
end_date = 'Thu Mar 25 00:00:00 UTC 2021',
start_date = 'Mon Mar 23 20:00:00 EDT 2020',
end_date = 'Wed Mar 24 20:00:00 EDT 2021',
modified = '2020-03-24T11:11:41.139-05:00',
created = '2020-03-24T11:11:41.139-05:00'
)
Expand Down
2 changes: 1 addition & 1 deletion sailpoint/beta/test/test_source_usage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def make_instance(self, include_optional) -> SourceUsage:
model = SourceUsage()
if include_optional:
return SourceUsage(
var_date = 'Fri Apr 21 00:00:00 UTC 2023',
var_date = 'Thu Apr 20 20:00:00 EDT 2023',
count = 10.45
)
else:
Expand Down
3 changes: 3 additions & 0 deletions sailpoint/v2024/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import os
import re
import tempfile
import xmltodict

from urllib.parse import quote
from typing import Tuple, Optional, List, Dict, Union
Expand Down Expand Up @@ -427,6 +428,8 @@ def deserialize(self, response_text: str, response_type: str, content_type: Opti
data = ""
else:
data = json.loads(response_text)
elif content_type.startswith("application/xml") or content_type.startswith("text/xml"):
data = xmltodict.parse(response_text)
elif content_type.startswith("text/plain"):
data = response_text
else:
Expand Down
2 changes: 1 addition & 1 deletion sailpoint/v2024/test/test_account_usage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def make_instance(self, include_optional) -> AccountUsage:
model = AccountUsage()
if include_optional:
return AccountUsage(
var_date = 'Fri Apr 21 00:00:00 UTC 2023',
var_date = 'Thu Apr 20 20:00:00 EDT 2023',
count = 10
)
else:
Expand Down
4 changes: 2 additions & 2 deletions sailpoint/v2024/test/test_non_employee_request_without_approval_item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ def make_instance(self, include_optional) -> NonEmployeeRequestWithoutApprovalIt
approval_status = 'APPROVED',
comment = 'approved',
completion_date = '2020-03-24T11:11:41.139-05:00',
start_date = 'Tue Mar 24 00:00:00 UTC 2020',
end_date = 'Thu Mar 25 00:00:00 UTC 2021',
start_date = 'Mon Mar 23 20:00:00 EDT 2020',
end_date = 'Wed Mar 24 20:00:00 EDT 2021',
modified = '2020-03-24T11:11:41.139-05:00',
created = '2020-03-24T11:11:41.139-05:00'
)
Expand Down
2 changes: 1 addition & 1 deletion sailpoint/v2024/test/test_source_usage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def make_instance(self, include_optional) -> SourceUsage:
model = SourceUsage()
if include_optional:
return SourceUsage(
var_date = 'Fri Apr 21 00:00:00 UTC 2023',
var_date = 'Thu Apr 20 20:00:00 EDT 2023',
count = 10.45
)
else:
Expand Down
3 changes: 3 additions & 0 deletions sailpoint/v3/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import os
import re
import tempfile
import xmltodict

from urllib.parse import quote
from typing import Tuple, Optional, List, Dict, Union
Expand Down Expand Up @@ -427,6 +428,8 @@ def deserialize(self, response_text: str, response_type: str, content_type: Opti
data = ""
else:
data = json.loads(response_text)
elif content_type.startswith("application/xml") or content_type.startswith("text/xml"):
data = xmltodict.parse(response_text)
elif content_type.startswith("text/plain"):
data = response_text
else:
Expand Down
2 changes: 1 addition & 1 deletion sailpoint/v3/test/test_account_usage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def make_instance(self, include_optional) -> AccountUsage:
model = AccountUsage()
if include_optional:
return AccountUsage(
var_date = 'Fri Apr 21 00:00:00 UTC 2023',
var_date = 'Thu Apr 20 20:00:00 EDT 2023',
count = 10
)
else:
Expand Down
4 changes: 2 additions & 2 deletions sailpoint/v3/test/test_non_employee_request_without_approval_item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ def make_instance(self, include_optional) -> NonEmployeeRequestWithoutApprovalIt
approval_status = 'APPROVED',
comment = 'approved',
completion_date = '2020-03-24T11:11:41.139-05:00',
start_date = 'Tue Mar 24 00:00:00 UTC 2020',
end_date = 'Thu Mar 25 00:00:00 UTC 2021',
start_date = 'Mon Mar 23 20:00:00 EDT 2020',
end_date = 'Wed Mar 24 20:00:00 EDT 2021',
modified = '2020-03-24T11:11:41.139-05:00',
created = '2020-03-24T11:11:41.139-05:00'
)
Expand Down
2 changes: 1 addition & 1 deletion sailpoint/v3/test/test_source_usage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def make_instance(self, include_optional) -> SourceUsage:
model = SourceUsage()
if include_optional:
return SourceUsage(
var_date = 'Fri Apr 21 00:00:00 UTC 2023',
var_date = 'Thu Apr 20 20:00:00 EDT 2023',
count = 10.45
)
else:
Expand Down
3 changes: 3 additions & 0 deletions sdk-resources/resources/api_client.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import mimetypes
import os
import re
import tempfile
import xmltodict

from urllib.parse import quote
from typing import Tuple, Optional, List, Dict, Union
Expand Down Expand Up @@ -435,6 +436,8 @@ class ApiClient:
data = ""
else:
data = json.loads(response_text)
elif content_type.startswith("application/xml") or content_type.startswith("text/xml"):
data = xmltodict.parse(response_text)
elif content_type.startswith("text/plain"):
data = response_text
else:
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
PYTHON_REQUIRES = ">=3.7"
REQUIRES = [
"urllib3 >= 1.25.3, < 2.1.0", "python-dateutil", "pydantic >= 2",
"typing-extensions >= 4.7.1",
"typing-extensions >= 4.7.1", "xmltodict>=0.14.2"
]

setup(
Expand Down