[udev] Improve PD charger detection. Fixes JB#60160 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are Doxygen warnings about unknown "credential" command. These credentals were used by Nokia N9/N950 Aegis security system. They are no longer relevant in any way and can simply be removed. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
Documenting return value for a function that does not return anything is causing doxygen warnings. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
USB mode selector pops up when USB-PD charger is connected. This happens because in case of PD connection usb charger power_supply device does not provide enough information for telling apart pc from charger. Enable tracking of /sys/class/extcon device nodes. For phones that report USB=1 state only on pc connection, this is enough information for pc or charger decision. In case of phone that report USB=1 both for pc and charger connections, enabling also tracking of /sys/class/android_usb device nodes can help. However this should be done via device specific configuration files as it can cause jitter and notification noise before reaching stable state. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
mlehtima
approved these changes
Feb 28, 2024
Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USB mode selector pops up when USB-PD charger is connected. This
happens because in case of PD connection usb charger power_supply
device does not provide enough information for telling apart pc
from charger.
Enable tracking of /sys/class/extcon device nodes. For phones that
report USB=1 state only on pc connection, this is enough information
for pc or charger decision.
In case of phone that report USB=1 both for pc and charger connections,
enabling also tracking of /sys/class/android_usb device nodes can help.
However this should be done via device specific configuration files as
it can cause jitter and notification noise before reaching stable state.