Remove transfer when privateMode is set #1057
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainemak
reviewed
Apr 18, 2024
| } | ||
| if (isPrivateMode) { | ||
| m_transferClient->clearTransfer(m_download2transferMap.value(downloadId)); | ||
| } |
There was a problem hiding this comment.
Small downloads disappear now really quickly. I doubt that people find downloaded files from the file system. Instead of immediately clearing, I think it would be nicer to gather a list of completed private downloadIds over here. Then upon clearing of PrivateTabModel (tab count reaching zero and destruction of the model) clear also private downloads from the DownloadManager. How do you see this?
Briefly chatted this with @pvuorela as well.
|
Small comment, could you please re-target this towards next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of transfer-engine!14, the goal here is to hide transfers made from a private tab.
I think that is OK to remove the transfer when it's completed, cancelled or failed.