Skip to content

Comments

Dialog: make cancel timeout configurable#500

Merged
nephros merged 3 commits intosailfishos-patches:masterfrom
nephros:splash-timeout
Apr 22, 2025
Merged

Dialog: make cancel timeout configurable#500
nephros merged 3 commits intosailfishos-patches:masterfrom
nephros:splash-timeout

Conversation

@nephros
Copy link
Contributor

@nephros nephros commented Apr 19, 2025

  • Dialog: make timeout configurable
  • Dialog: use non-deprecated import
  • Dialog: allow any orientation
  • Dialog: Fix a warning

Contributes-To: #480

Copy link
Contributor

@Olf0 Olf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nephros nephros merged commit 026fa6b into sailfishos-patches:master Apr 22, 2025
1 check passed
@nephros nephros deleted the splash-timeout branch April 22, 2025 08:23
@Olf0
Copy link
Contributor

Olf0 commented May 11, 2025

@nephros, when trying to translate string #111 at Transifex, it appears to me that a "when rebooting" is missing in the original source string to make sense, correct?

Maybe we can even drop the lengthy "for the first time" and simply replace it with "when rebooting"?


It also looks as if Transifex's string #121 (original source string here) then needs to be adapted accordingly, too: Both, to the recent changes of string #111 and the resolution of its issue addressed here.


Less, but still slightly problematic appears to be string #46 at Transifex when comparing it to my draft of its de translation there (original source string here). It is not a brand new string, but when reviewing it now, it seems to provide too little information.


Edit: Transferred (in)to issue #504.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants