Add support for new release URL macro of SailfishOS 4.6 #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without it, test builds fail in OBS
|
doesn't work yet, few more changes are needed |
Olf0
reviewed
May 23, 2024
Olf0
reviewed
May 23, 2024
Neither do I. Though I have two comments WRT the added code, see above. |
|
I have installed this on a pinetab2 running 4.6.0.11, and after removing the override I had in place for the SFOS Version, the correct URL was used for the chum repository and packages are available in the UI |
|
@piggz, thanks! |
Olf0
changed the title
|
@Olf0, thank you very much for resolving the regex. ready to merge? |
Yes, sure, please squash-merge. I will create a release then (already did a little preparation), and notify you by a push to |
|
Thanks, merged |
Olf0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to new URL macro in SFOS >= 4.6. In longer term, allows to reduce the load on OBS and its administration
Reenable processing of the version string before adding it as CMake option. Without it, test builds will fail at OBS
Test build available at https://build.sailfishos.org/package/show/home:rinigus:tmp/sailfishos-chum-gui
Please check on SFOS 4.6.x.x as I don't have access to it. For that, use GUI build from 4.6 repo
Fixes: #270