Metadata: parse new names #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 23, 2023 07:54
- PackageName || Title - PackagerName || PackagedBy - Icon || PackageIcon - Url || Links
Olf0
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
LGTM
Thank you very much, will overhaul the section "field descriptions" of Metadata.md in the upcoming days.
This was referenced Mar 24, 2023
|
Thank you very much, LGTM |
|
@nephros, unfortunately this change fails to compile: Can you please take a look at it. |
|
Damn, missing closing bracket. Sorry about that. Fixes coming up! |
… which I failed to see (despite being trivial) due to being overly tired when I detected that building fails.
Never mind. It uncovered another issues: The CI runs at GitHub show success, even though compiling fails! I have to improve the workflow definition(s).
|
Olf0
added a commit
to sailfishos-chum/main
that referenced
this pull request
Apr 4, 2023
References: - [Issue \#100 "Draft a version of the metadata specification"](#100) - [PR \#181 "Metadata: parse new names" for the SailfishOS:Chum GUI application](sailfishos-chum/sailfishos-chum-gui#181).
Olf0
added a commit
to sailfishos-chum/main
that referenced
this pull request
Apr 6, 2023
…ion (#109) * Replace four tags and document this in the text References: - [Issue \#100 "Draft a version of the metadata specification"](#100) - [PR \#181 "Metadata: parse new names" for the SailfishOS:Chum GUI application](sailfishos-chum/sailfishos-chum-gui#181). * Update link to final metadata definition v0 * Add proper headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements parsing new tags
See sailfishos-chum/main#100
As the implementor I have taken the liberty of supporting PackagedBy as well, because I like it.