Update notification doesn't include package name and version [Bug]

[spodermenpls]

Sailfish OS VERSION: 4.6.0.15 and earlier

HARDWARE: Sony Xperia XA2

SailfishOS:Chum GUI application VERSION: 0.6.8-1 and earlier

BUG DESCRIPTION

According to the locale string %1 %2 updated, %1 is supposed to act as a placeholder for the package name and %2 as a placeholder for the package version, that get displayed in a notification popup after a successful package update. However, package name and version never get displayed on my end, and have never done so (at least to my recollection) in the past either, it only displays "updated", or in my German case "aktualisiert" (which was the original thing that made me pay attention, since if indeed intended as a single word, it should be spelled with a capital "A" in that scenario). The notifications after Install or Remove operations however do include package name and version, as intended.

STEPS TO REPRODUCE

If there's at least one update for a package available (unfortunately not that easy to re-create on demand..), execute it from the pulley menu and observe the notification pop-up banner after it is done.

ADDITIONAL INFORMATION

As mentioned in #167:

Affected strings in source TS file:
https://github.com/sailfishos-chum/sailfishos-chum-gui/blob/main/translations/sailfishos-chum-gui.ts#L39-L56

Corresponding code:
https://github.com/sailfishos-chum/sailfishos-chum-gui/blob/main/qml/sailfishos-chum-gui.qml#L13-L30

_{[Please consider which other pieces of information may be relevant: Denote if this is not always reproducible, if this is a regression (then name to which older version), attach relevant data such as log files or the systemd journal, provide screenshots etc.]}

[Olf0]

Thank you very much @spodermenpls for this excellent bug report. I will take a closer look at the corresponding code, when I find some time for SailfishOS-related things (but not the next couple of days, unfortunately).

[spodermenpls]

Now that rinigus pushed updates for OSM Scout Server (and Pure Maps), I was able to make two screenshots of the phenomenon I was describing above:

[Olf0]

Oops, I intended to do the same what you did now: Look at this issue when update candidates exist, respectively when updating them. Unfortunately I forgot, hence thank you for reminding me of this issue.

I now tried to understand the code location, for which you nicely provided a link in the OP. Now I wonder, too: Why is not the usual scheme for emitting notifications used (as e.g. here), and where is the corresponding qtTrId() which ultimately outputs these strings (as in the Qt documentation example for QT_TRID_NOOP), etc.? Actually I do not comprehend how this code outputs the truncated message "updated" (respectively "aktualisiert" in German) successfully, as your screenshots show. But as I avoid writing JavaScript code as much as I can, I have little knowledge and experience with QML and JavaScript.

@piggz, as you authored this code (though three years ago), can you please take a look at this issue. The SailfishOS:Chum GUI app versions 0.6.9 and 0.7.0 bear no change in this regard (the OP addresses v0.6.8). Mind that in above screenshots only the notification bar at the very top of the screen is relevant (i.e. the topic of this issue). Thanks!

[Olf0]

@piggz, sorry to have stubbornly assigned this issue to you, as I assume this still is an less-annoying way to get your attention (and within the functionality of GH's web-frontend) than receiving a PM. Anyway, this issue can be re- or un-assigned at any time if you wish.

[rinigus]

I must say it is a low priority right now for me and I suspect the same is for @piggz. I am personally swamped with another SFOS project and would prefer to focus on that. @piggz is busy with Qt6 and probably few other projects. So, unless someone steps in, it would have to wait.