Skip to content

Commit

Permalink
Merge pull request pytorch#325 from pjh5/cuda_version_string
Browse files Browse the repository at this point in the history
Fix urls for +cuver versions
  • Loading branch information
pjh5 authored Jul 25, 2019
2 parents 30bf35f + 2507ab2 commit 24c3f46
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
8 changes: 4 additions & 4 deletions cron/upload_binary_sizes.sh
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@ failed_binary_queries=()
# Collect conda binary sizes
# This is read from `conda search`.

# `conda search` takes a version string. We use *20190101 to catch
# 1.0.0.dev20190101 or 1.1.0.dev20190101 etc. All the nightly binaries have
# this general format of version string
conda_search_version="*$(echo $target_date | tr -d _)"
# `conda search` takes a version string. We use *20190101* to catch
# 1.0.0.dev20190101 or 1.1.0.dev20190101+cu90 etc. All the nightly binaries
# have this general format of version string
conda_search_version="*$(echo $target_date | tr -d _)*"

conda_platforms=('linux-64' 'osx-64')
conda_pkg_names=('pytorch-nightly' 'pytorch-nightly-cpu')
Expand Down
4 changes: 4 additions & 0 deletions smoke_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,10 @@ elif [[ "$PACKAGE_TYPE" == 'conda' ]]; then
retry conda install -yq -c pytorch "cudatoolkit=$CUDA_VERSION_SHORT" "$package_name_and_version"
fi
else
# We need to upgrade pip now that we have '+cuver' in the package name, as
# old pips do not correctly change the '+' to '%2B' in the url and fail to
# find the package.
pip install --upgrade pip -q
pip_url="https://download.pytorch.org/whl/nightly/$DESIRED_CUDA/torch_nightly.html"
retry pip install "$package_name_and_version" \
-f "$pip_url" \
Expand Down

0 comments on commit 24c3f46

Please sign in to comment.