fix: format date-time validation

sagold · Jun 6, 2024 · 1096736 · 1096736
1 parent 94cf3ec
commit 1096736
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/validation/format.ts b/lib/validation/format.ts
@@ -70,11 +70,13 @@ const formatValidators: Record<
         if (typeof value !== "string" || value === "") {
             return undefined;
         }
-        if (value === "" || isValidDateTime.test(value)) {
-            if (new Date(value).toString() === "Invalid Date") {
-                return draft.errors.formatDateTimeError({ value, pointer, schema });
+        const dateAndTime = value.split(/t/i);
+        if (dateAndTime.length === 2) {
+            const dateIsValid = formatValidators.date(node, dateAndTime[0]) === undefined;
+            const timeIsValid = formatValidators.time(node, dateAndTime[1]) === undefined;
+            if (dateIsValid && timeIsValid) {
+                return undefined;
             }
-            return undefined;
         }
         return draft.errors.formatDateTimeError({ value, pointer, schema });
     },

diff --git a/test/spec/v2019-09/draft2019-09.test.ts b/test/spec/v2019-09/draft2019-09.test.ts
@@ -34,8 +34,6 @@ const supportedTestCases = (t: FeatureTest) =>
         "ecmascript-regex", // should
         "float-overflow",
         "dependencies-compatibility", // should
-        "format-date-time", // MUST
-        // "format-time", // MUST
         "format-iri",
         "format-iri-reference",
         "format-idn-hostname",
@@ -46,7 +44,7 @@ const supportedTestCases = (t: FeatureTest) =>
 
 const draftFeatureTests = getDraftTests("2019-09")
     // .filter((testcase) => testcase.name === "dependencies-compatibility")
-    // .filter((testcase) => testcase.name === "format-time")
+    // .filter((testcase) => testcase.name === "format-date-time")
     .filter(supportedTestCases);
 
 /*