Skip to content
This repository was archived by the owner on Dec 16, 2024. It is now read-only.

Conversation

schlamar
Copy link
Collaborator

@schlamar schlamar commented May 5, 2017

No description provided.

@saghul
Copy link
Owner

saghul commented May 6, 2017

Hey there! The failure on Travis seems like a Travis issue, but the AppVeyor one could somehow be legit.

@schlamar
Copy link
Collaborator Author

schlamar commented May 8, 2017

Oh yes, there is really a regression in 3.6+ (see Travis). Any idea?

@schlamar
Copy link
Collaborator Author

schlamar commented May 8, 2017

Please see: https://bugs.python.org/issue26685

I guess we should just remove the sock.close call?!

@schlamar
Copy link
Collaborator Author

schlamar commented May 8, 2017

Not sure about the UDP test case though. There is a different behavior on Linux and Windows. Is pyuv or libuv closing the underlying socket on bind error on Linux?

@schlamar
Copy link
Collaborator Author

schlamar commented May 8, 2017

@schlamar
Copy link
Collaborator Author

schlamar commented May 8, 2017

Reported upstream: libuv/libuv#1336

@saghul
Copy link
Owner

saghul commented May 8, 2017

Thanks for digging though it! I think the current workaround looks ok!

@schlamar
Copy link
Collaborator Author

schlamar commented May 8, 2017

Are you planning a new release any time soon? If not we could create a temporary branch based on the pyuv-1.3.0 tag with these changes so AppVeyor is building the Python 3.6 wheels for 1.3.0. :)

@schlamar
Copy link
Collaborator Author

@saghul Ping :)

@schlamar
Copy link
Collaborator Author

schlamar commented May 31, 2017

@saghul Should I squash this in one commit? ci, test: add proper support for Python 3.6?

@schlamar
Copy link
Collaborator Author

New proposal (see commits)

Copy link
Owner

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@schlamar schlamar merged commit 480d721 into saghul:v1.x Jun 1, 2017
@schlamar schlamar deleted the patch-1 branch June 1, 2017 07:06
@schlamar
Copy link
Collaborator Author

schlamar commented Jun 1, 2017

BTW, setuptools has broken the Travis builds :/

pypa/setuptools#1042

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants