Skip to content

docs(recipes): Add "mini.icons + lspkind" combination to recipes.md#2121

Merged
saghen merged 2 commits intosaghen:mainfrom
dybdeskarphet:main
Sep 2, 2025
Merged

docs(recipes): Add "mini.icons + lspkind" combination to recipes.md#2121
saghen merged 2 commits intosaghen:mainfrom
dybdeskarphet:main

Conversation

@dybdeskarphet
Copy link
Contributor

@dybdeskarphet dybdeskarphet commented Aug 27, 2025

This PR implements what is described in the title. I tested it on my Neovim setup, and everything works as expected.

Context: I like lspkind icons, but I don’t want to rely on nvim-web-devicons. With minimal setups becoming more popular, I think this addition would be nice.

@saghen
Copy link
Owner

saghen commented Sep 2, 2025

Thanks! Moved the icon recipes to the bottom since they're so long, and cleaned up your recipe a bit. If anything's wrong, lmk and I can patch it on main or feel free to open another PR.

@saghen saghen merged commit 4e26eea into saghen:main Sep 2, 2025
1 check passed
@dybdeskarphet
Copy link
Contributor Author

dybdeskarphet commented Sep 2, 2025

@saghen So the problem is, I recenetly discovered that ctx.item.data.type can be "link" and mini.icons doesn't have that category. For instance, while writing shebangs.

I apologize for opening this PR without testing more instances. And what should I do know? Revert this PR?

image

@saghen
Copy link
Owner

saghen commented Sep 2, 2025

No worries at all, opening a new PR with a fix would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants