Skip to content

Enforce previously fixed lint rules #40539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tqa236
Copy link
Contributor

@tqa236 tqa236 commented Aug 3, 2025

Enforce several previously fixed lint rules that can't be done at the same time due to merge conflict

The change was tested in this 671c729 and worked.

The discussion is in the same PR: #40419

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@tobiasdiez
Copy link
Contributor

Thanks for the PR. If you activate the rules in pyproject.toml (under select), then they are also in effect for other tools (eg code editors) and if you run it locally. It probably even makes sense to activate the full namespace (eg FURB) and then deactivate the failing rules on CI.

Copy link

github-actions bot commented Aug 3, 2025

Documentation preview for this PR (built with commit f276821; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tqa236
Copy link
Contributor Author

tqa236 commented Aug 3, 2025

hi @tobiasdiez, thank you for your comment. I asked about where to put it here and followed @fchapoton's suggestion in putting it in lint.yml.

If there's a consensus about where to put the config, I'm happy to make the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants