-
-
Notifications
You must be signed in to change notification settings - Fork 598
some cleanup in matrix1.pyx #39888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fchapoton
wants to merge
1
commit into
sagemath:develop
Choose a base branch
from
fchapoton:clean_matrix1
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
some cleanup in matrix1.pyx #39888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview for this PR (built with commit d5a4649; changes) is ready! 🎉 |
dcoudert
approved these changes
Apr 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 5, 2025
mostly cosmetic code formatting (pycodestyle suggestions) ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39888 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 7, 2025
sagemathgh-39888: some cleanup in matrix1.pyx mostly cosmetic code formatting (pycodestyle suggestions) ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39888 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 10, 2025
sagemathgh-39888: some cleanup in matrix1.pyx mostly cosmetic code formatting (pycodestyle suggestions) ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39888 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 13, 2025
sagemathgh-39888: some cleanup in matrix1.pyx mostly cosmetic code formatting (pycodestyle suggestions) ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39888 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 18, 2025
sagemathgh-39888: some cleanup in matrix1.pyx mostly cosmetic code formatting (pycodestyle suggestions) ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39888 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly cosmetic code formatting (pycodestyle suggestions)
📝 Checklist