Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize MatchingCoveredGraph’s add_edge method #39678

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mashraf8
Copy link

The add_edge method has been optimized to ensure that edges are added while preserving the matching-covered property without fully reinitializing or creating a new graph.

First, the edge is added using the base method, then the graph is checked to confirm that it remains matching-covered. If it is no longer valid, the edge is immediately removed to restore the previous state. The matching is updated only if the graph remains valid.

Doctests were successfully executed to verify the correctness of the modifications.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@mashraf8
Copy link
Author

Hi @dcoudert,

I'm new to contributing to SageMath and actively exploring its environment as I prepare for GSoC. My goal is to become a long-term contributor, and I'm gaining familiarity with the codebase through various contributions. Looking forward to your feedback on this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant