Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some typing in Permutation #39613

Merged
merged 1 commit into from
Mar 9, 2025
Merged

Conversation

fchapoton
Copy link
Contributor

and a few other minor details in the modified file

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

Copy link

github-actions bot commented Mar 1, 2025

Documentation preview for this PR (built with commit 130e833; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (although the int from Integer feels slightly bad to me since we don't want Python ints escaping...I'd rather fix those outputs).

vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 9, 2025
sagemathgh-39613: some typing in Permutation
    
and a few other minor details in the modified file

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39613
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit 392e467 into sagemath:develop Mar 9, 2025
23 of 24 checks passed
@fchapoton fchapoton deleted the typing_permutation branch March 11, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants