Doctest for defining multivariate polynomial ring over InfinityRing #39573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 2732887; changes) is ready! 🎉 |
|
In line 625, please put double back-ticks around InfinityRing, so it is formatted correctly (i.e., with the correct font) in the documentation: ``InfinityRing``. |
|
Looks good, thanks. (The CI failure is a doctest that often fails. It is presumably not related to this PR.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34675
Previously, defining a multivariate polynomial ring over InfinityRing would incorrectly result in an error. As mentioned in the comments under the linked issue, this behaviour was fixed in version 10.3 but a doctest was still needed.
This pull request adds the required doctest, verifying that the statement
PolynomialRing(InfinityRing,2,'x')correctly generates a ring instead of throwing an error.📝 Checklist
⌛ Dependencies