Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and activate the check for pep E272 #39552

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

fchapoton
Copy link
Contributor

and also cleaning the two modified files

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

Copy link

github-actions bot commented Feb 20, 2025

Documentation preview for this PR (built with commit d44a769; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton
Copy link
Contributor Author

voilà. merci pour la relecture

@dcoudert
Copy link
Contributor

don't forget to push the changes ;)

@fchapoton
Copy link
Contributor Author

oups, désolé

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Unless I'm mistaken, the 2 failing CI are independent from this PR.

@fchapoton
Copy link
Contributor Author

merci David

vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 22, 2025
sagemathgh-39552: fix and activate the check for pep E272
    
and also cleaning the two modified files

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39552
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 24, 2025
sagemathgh-39552: fix and activate the check for pep E272
    
and also cleaning the two modified files

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39552
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
@vbraun vbraun merged commit c2d418a into sagemath:develop Feb 28, 2025
21 of 23 checks passed
@fchapoton fchapoton deleted the pep8_code_E272 branch March 1, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants