Improvement to flint_autogen reader #39530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
user202729
force-pushed
the
flint-reader-backslash
branch
from
c2b66e6 to
a787dec
Compare
|
Documentation preview for this PR (built with commit a787dec; changes) is ready! 🎉 |
user202729
changed the title
fchapoton
added
c: packages: standard
s: positive review
and removed
s: needs review
labels
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 18, 2025
sagemathgh-39530: Improvement to flint_autogen reader See sagemath#39413 (comment) In flint latest master, there's this thing ``` .. function:: void n_mulmod_and_precomp_shoup(ulong * ab, ulong * ab_precomp, \ ulong a, ulong b, \ ulong a_pr_quo, ulong a_pr_rem, ulong b_precomp, \ ulong n) ``` In order to parse this (trailing backslash), it is necessary to modify `flint_autogen.py`. Now I only handled it for function so far. Also some minor unrelated changes. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. (no change) ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39530 Reported by: user202729 Reviewer(s): Frédéric Chapoton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #39413 (comment)
In flint latest master, there's this thing
In order to parse this (trailing backslash), it is necessary to modify
flint_autogen.py. Now I only handled it for function so far.Also some minor unrelated changes.
📝 Checklist
⌛ Dependencies