convert gens method in modular to return tuple #39474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit f910c56; changes) is ready! 🎉 |
|
|
||
| # For modular forms spaces the quasi parts are all zero except for r=0 | ||
| if (self.is_modular()): | ||
| if self.is_modular(): | ||
| r = ZZ(r) |
There was a problem hiding this comment.
I remember you saying in another PR that Integer is faster than ZZ. Fine to leave it since the PR is addressing typing annotations. Perhaps a find/replace ZZ with Integer is something worth doing in another PR.
vincentmacri
approved these changes
Feb 11, 2025
|
LGTM |
vincentmacri
added
s: positive review
t: refactoring
and removed
s: needs review
labels
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 18, 2025
sagemathgh-39474: convert gens method in modular to return tuple and add typing annotation to remember that this is done ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39474 Reported by: Frédéric Chapoton Reviewer(s): Vincent Macri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add typing annotation to remember that this is done
📝 Checklist