Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing PLW0120 #39384

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fixing PLW0120 #39384

merged 1 commit into from
Feb 10, 2025

Conversation

fchapoton
Copy link
Contributor

this is about wrong use of else in for loops without break

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

Copy link

Documentation preview for this PR (built with commit 0a94fbb; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@vincentmacri vincentmacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 28, 2025
this is about wrong use of `else` in `for` loops without `break`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.

URL: sagemath#39384
Reported by: Frédéric Chapoton
Reviewer(s): Vincent Macri
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 29, 2025
sagemathgh-39384: fixing PLW0120
    
this is about wrong use of `else` in `for` loops without `break`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39384
Reported by: Frédéric Chapoton
Reviewer(s): Vincent Macri
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 30, 2025
sagemathgh-39384: fixing PLW0120
    
this is about wrong use of `else` in `for` loops without `break`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39384
Reported by: Frédéric Chapoton
Reviewer(s): Vincent Macri
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 31, 2025
sagemathgh-39384: fixing PLW0120
    
this is about wrong use of `else` in `for` loops without `break`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39384
Reported by: Frédéric Chapoton
Reviewer(s): Vincent Macri
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 3, 2025
sagemathgh-39384: fixing PLW0120
    
this is about wrong use of `else` in `for` loops without `break`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39384
Reported by: Frédéric Chapoton
Reviewer(s): Vincent Macri
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 4, 2025
sagemathgh-39384: fixing PLW0120
    
this is about wrong use of `else` in `for` loops without `break`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39384
Reported by: Frédéric Chapoton
Reviewer(s): Vincent Macri
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 9, 2025
sagemathgh-39384: fixing PLW0120
    
this is about wrong use of `else` in `for` loops without `break`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39384
Reported by: Frédéric Chapoton
Reviewer(s): Vincent Macri
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 9, 2025
sagemathgh-39384: fixing PLW0120
    
this is about wrong use of `else` in `for` loops without `break`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39384
Reported by: Frédéric Chapoton
Reviewer(s): Vincent Macri
@vbraun vbraun merged commit 10380b9 into sagemath:develop Feb 10, 2025
21 of 24 checks passed
@fchapoton fchapoton deleted the fix_PLW0120 branch February 11, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants