Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

totally trivial space adding ticket #39327

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Conversation

fchapoton
Copy link
Contributor

totally boring job

  • adding some spaces in comments
  • changing python2 syntax to python3 in commented code

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

# raise TypeError, "X (=%s) must be in category (=%s)"%(X, category)
#if not Y in category:
# raise TypeError, "Y (=%s) must be in category (=%s)"%(Y, category)
# if not X in category:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this commented out code here at all?

Copy link
Contributor

@vincentmacri vincentmacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you want to remove some or all of the commented out code blocks I'd be okay with that too.

Copy link

github-actions bot commented Jan 14, 2025

Documentation preview for this PR (built with commit 67f93b8; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton
Copy link
Contributor Author

merci !

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 23, 2025
sagemathgh-39327: totally trivial space adding ticket
    
totally boring job

- adding some spaces in comments
- changing python2 syntax to python3 in commented code

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39327
Reported by: Frédéric Chapoton
Reviewer(s): Vincent Macri
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 25, 2025
sagemathgh-39327: totally trivial space adding ticket
    
totally boring job

- adding some spaces in comments
- changing python2 syntax to python3 in commented code

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39327
Reported by: Frédéric Chapoton
Reviewer(s): Vincent Macri
@vbraun vbraun merged commit a2c86f4 into sagemath:develop Jan 27, 2025
20 of 22 checks passed
@fchapoton fchapoton deleted the trivial_space branch January 27, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants