Specify use_sources=True in cython compilation #39275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 6478f43; changes) is ready! 🎉 |
2 tasks
|
has this fixed any failing tests? |
|
for some reason (probably some path coincidence or whatever) it works fine on CI either way. Maybe I should figure out some way to test it on CI. |
3 tasks
|
Please post an explicit example of what fails for you, and the specifics of your Cython setup. |
|
Okay here it is: if e.g. https://github.com/sagemath/sage/actions/runs/12913561812/job/36011095007#step:10:14938 Side note, do you think it's desirable to test all combinations (Python 3.11, 12 × editable: true, false) each pull request? Or we could cut down to only test e.g. {Python 3.11 non-editable, Python 3.12 editable} on pull request and test the full matrix in pushes to branch. |
|
There's a bunch of additional things that fail with Maybe we can just merge the first commit in and enable |
tobiasdiez
approved these changes
Feb 5, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 9, 2025
sagemathgh-39275: Specify use_sources=True in cython compilation In my testing, this allows cython compilation of code with `from sage.[...] cimport [...]` to work when built with meson. Ability to compile cython code when use legacy build system is unaffected. Actually without this change cython compilation works fine on conda & meson CI anyway (probably because of some coincidence, I didn't inspect) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39275 Reported by: user202729 Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 9, 2025
sagemathgh-39275: Specify use_sources=True in cython compilation In my testing, this allows cython compilation of code with `from sage.[...] cimport [...]` to work when built with meson. Ability to compile cython code when use legacy build system is unaffected. Actually without this change cython compilation works fine on conda & meson CI anyway (probably because of some coincidence, I didn't inspect) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39275 Reported by: user202729 Reviewer(s): Tobias Diez
2 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 9, 2025
sagemathgh-39369: Test pip editable install with meson Tests pip editable install with meson on GitHub Actions. This uncovers several failing tests, which are fixed by (see dependencies below) Note: review is hard because of the large number of dependencies. It is probably easier to look only in `.github` folder. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. ### ⌛ Dependencies - sagemath#39423 - sagemath#39498 - sagemath#39494 - sagemath#39424 - sagemath#39275 - sagemath#39499 URL: sagemath#39369 Reported by: user202729 Reviewer(s): Tobias Diez, user202729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my testing, this allows cython compilation of code with
from sage.[...] cimport [...]to work when built with meson. Ability to compile cython code when use legacy build system is unaffected.Actually without this change cython compilation works fine on conda & meson CI anyway (probably because of some coincidence, I didn't inspect)
📝 Checklist
⌛ Dependencies