add parameter immutable to generators in sage/graphs/digraph_generators.py (part 2)
#39266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit c08051e; changes) is ready! 🎉 |
5 tasks
|
I don't think the error reported in https://github.com/sagemath/sage/actions/runs/12984647749/job/36207939071?pr=39266#step:10:5598 is related to this PR. May be the error is due to the declaration |
fchapoton
reviewed
Feb 11, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 18, 2025
sagemathgh-39266: add parameter immutable to generators in `sage/graphs/digraph_generators.py` (part 2) Following sagemath#39264, we add parameter immutable to `DeBruijn`, `GeneralizedDeBruijn`, `Kautz` and `ImaseItoh`. We also add parameter `name` to `GeneralizedDeBruijn` and `ImaseItoh` to ease calls from `DeBruijn` and `Kautz`. This PR is motivated by discussions in sagemath#39177. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39266 Reported by: David Coudert Reviewer(s): David Coudert, Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 1, 2025
sagemathgh-39269: add parameter immutable to generators in `sage/graphs/digraph_generators.py` (part 3) Following sagemath#39264 and sagemath#39266, we add parameter immutable to the remaining digraph generators. This PR is motivated by discussions in sagemath#39177. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39269 Reported by: David Coudert Reviewer(s): David Coudert, Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 2, 2025
sagemathgh-39269: add parameter immutable to generators in `sage/graphs/digraph_generators.py` (part 3) Following sagemath#39264 and sagemath#39266, we add parameter immutable to the remaining digraph generators. This PR is motivated by discussions in sagemath#39177. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39269 Reported by: David Coudert Reviewer(s): David Coudert, Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 3, 2025
sagemathgh-39269: add parameter immutable to generators in `sage/graphs/digraph_generators.py` (part 3) Following sagemath#39264 and sagemath#39266, we add parameter immutable to the remaining digraph generators. This PR is motivated by discussions in sagemath#39177. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39269 Reported by: David Coudert Reviewer(s): David Coudert, Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 9, 2025
sagemathgh-39269: add parameter immutable to generators in `sage/graphs/digraph_generators.py` (part 3) Following sagemath#39264 and sagemath#39266, we add parameter immutable to the remaining digraph generators. This PR is motivated by discussions in sagemath#39177. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39269 Reported by: David Coudert Reviewer(s): David Coudert, Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 9, 2025
sagemathgh-39269: add parameter immutable to generators in `sage/graphs/digraph_generators.py` (part 3) Following sagemath#39264 and sagemath#39266, we add parameter immutable to the remaining digraph generators. This PR is motivated by discussions in sagemath#39177. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39269 Reported by: David Coudert Reviewer(s): David Coudert, Frédéric Chapoton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #39264, we add parameter immutable to
DeBruijn,GeneralizedDeBruijn,KautzandImaseItoh.We also add parameter
nametoGeneralizedDeBruijnandImaseItohto ease calls fromDeBruijnandKautz.This PR is motivated by discussions in #39177.
📝 Checklist
⌛ Dependencies