Minor refactor for is_exact #39137
Merged
Minor refactor for is_exact #39137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user202729
force-pushed
the
refactor-is-exact
branch
from
5d8d175 to
e23375f
Compare
|
Documentation preview for this PR (built with commit 06bd6f4; changes) is ready! 🎉 |
|
looks interesting, No time to double check now. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 29, 2025
sagemathgh-39137: Minor refactor for is_exact The method is unnecessarily duplicated, which this pull request removes. Besides, it wasn't originally correctly implemented for modules and matrix spaces. Fixed now. Side note: technically a matrix space over R is a (usually noncommutative) R-algebra, which is in turn a R-module. Yet MatrixSpace doesn't inherit from Module? ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39137 Reported by: user202729 Reviewer(s): Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 30, 2025
sagemathgh-39137: Minor refactor for is_exact The method is unnecessarily duplicated, which this pull request removes. Besides, it wasn't originally correctly implemented for modules and matrix spaces. Fixed now. Side note: technically a matrix space over R is a (usually noncommutative) R-algebra, which is in turn a R-module. Yet MatrixSpace doesn't inherit from Module? ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39137 Reported by: user202729 Reviewer(s): Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 31, 2025
sagemathgh-39137: Minor refactor for is_exact The method is unnecessarily duplicated, which this pull request removes. Besides, it wasn't originally correctly implemented for modules and matrix spaces. Fixed now. Side note: technically a matrix space over R is a (usually noncommutative) R-algebra, which is in turn a R-module. Yet MatrixSpace doesn't inherit from Module? ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39137 Reported by: user202729 Reviewer(s): Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 3, 2025
sagemathgh-39137: Minor refactor for is_exact The method is unnecessarily duplicated, which this pull request removes. Besides, it wasn't originally correctly implemented for modules and matrix spaces. Fixed now. Side note: technically a matrix space over R is a (usually noncommutative) R-algebra, which is in turn a R-module. Yet MatrixSpace doesn't inherit from Module? ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39137 Reported by: user202729 Reviewer(s): Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 4, 2025
sagemathgh-39137: Minor refactor for is_exact The method is unnecessarily duplicated, which this pull request removes. Besides, it wasn't originally correctly implemented for modules and matrix spaces. Fixed now. Side note: technically a matrix space over R is a (usually noncommutative) R-algebra, which is in turn a R-module. Yet MatrixSpace doesn't inherit from Module? ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39137 Reported by: user202729 Reviewer(s): Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 9, 2025
sagemathgh-39137: Minor refactor for is_exact The method is unnecessarily duplicated, which this pull request removes. Besides, it wasn't originally correctly implemented for modules and matrix spaces. Fixed now. Side note: technically a matrix space over R is a (usually noncommutative) R-algebra, which is in turn a R-module. Yet MatrixSpace doesn't inherit from Module? ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39137 Reported by: user202729 Reviewer(s): Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 9, 2025
sagemathgh-39137: Minor refactor for is_exact The method is unnecessarily duplicated, which this pull request removes. Besides, it wasn't originally correctly implemented for modules and matrix spaces. Fixed now. Side note: technically a matrix space over R is a (usually noncommutative) R-algebra, which is in turn a R-module. Yet MatrixSpace doesn't inherit from Module? ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39137 Reported by: user202729 Reviewer(s): Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 11, 2025
sagemathgh-39212: Refactor period lattice Improvement for sagemath#38474 . (previously I didn't know `is_exact()` exists, thus the ugly `isinstance()` check.) Also now it works with RDF and CDF. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies Requires sagemath#39137 . URL: sagemath#39212 Reported by: user202729 Reviewer(s): Kwankyu Lee, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 18, 2025
sagemathgh-39212: Refactor period lattice Improvement for sagemath#38474 . (previously I didn't know `is_exact()` exists, thus the ugly `isinstance()` check.) Also now it works with RDF and CDF. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies Requires sagemath#39137 . URL: sagemath#39212 Reported by: user202729 Reviewer(s): Kwankyu Lee, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 21, 2025
sagemathgh-39212: Refactor period lattice Improvement for sagemath#38474 . (previously I didn't know `is_exact()` exists, thus the ugly `isinstance()` check.) Also now it works with RDF and CDF. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies Requires sagemath#39137 . URL: sagemath#39212 Reported by: user202729 Reviewer(s): Kwankyu Lee, user202729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method is unnecessarily duplicated, which this pull request removes.
Besides, it wasn't originally correctly implemented for modules and matrix spaces. Fixed now.
Side note: technically a matrix space over R is a (usually noncommutative) R-algebra, which is in turn a R-module. Yet MatrixSpace doesn't inherit from Module?
📝 Checklist
⌛ Dependencies