Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the last use of PrincipalIdealDomain #38922

Merged
merged 2 commits into from
Nov 16, 2024
Merged

remove the last use of PrincipalIdealDomain #38922

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e62310c
remove the last use of PrincipalIdealDomain
fchapoton Nov 4, 2024
e798f08
fix mistake
fchapoton Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/sage/rings/polynomial/polynomial_ring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@
from sage.categories.principal_ideal_domains import PrincipalIdealDomains
from sage.categories.rings import Rings

from sage.rings.ring import (Ring, IntegralDomain, PrincipalIdealDomain)
from sage.rings.ring import (Ring, IntegralDomain)
from sage.structure.element import RingElement
import sage.rings.rational_field as rational_field
from sage.rings.rational_field import QQ
Expand Down Expand Up @@ -2154,8 +2154,7 @@
implementation=implementation), self.base_ring()


class PolynomialRing_field(PolynomialRing_integral_domain,
PrincipalIdealDomain):
class PolynomialRing_field(PolynomialRing_integral_domain):
def __init__(self, base_ring, name='x', sparse=False, implementation=None,
element_class=None, category=None):
"""
Expand Down Expand Up @@ -2217,9 +2216,14 @@
from sage.rings.polynomial.polynomial_element_generic import Polynomial_generic_dense_field
return Polynomial_generic_dense_field

if category is None:
cat = PrincipalIdealDomains()
else:
cat = category & PrincipalIdealDomains()

Check warning on line 2222 in src/sage/rings/polynomial/polynomial_ring.py

View check run for this annotation

Codecov / codecov/patch

src/sage/rings/polynomial/polynomial_ring.py#L2222 

Added line #L2222 was not covered by tests

PolynomialRing_integral_domain.__init__(self, base_ring, name=name,
sparse=sparse, implementation=implementation,
element_class=_element_class(), category=category)
element_class=_element_class(), category=cat)

def _ideal_class_(self, n=0):
"""
Expand Down
Loading