Dokchitser: Pass internal parameter over properly #38482
Conversation
|
Documentation preview for this PR (built with commit d8a89d0; changes) is ready! 🎉 |
|
I don't know what the Let's see if the tests pass. (Edit: Looks like it pass, the failures appears to be unrelated to the change.) |
|
Maybe @robertwb can give a review and check if the intention of |
|
note that the Dokchitser implementation is rather here as an legacy (maybe even obsolete) one, as there is similar code included in pari, for which we do have an interface already in place |
|
I guess we could add that to the documentation too, pointing out it is deprecated and what is the equivalent new interface. That said, the program is just a script in pari/gp? |
|
does not build, typo on line 526 |
sagemathgh-38482: Dokchitser: Pass internal parameter over properly Previously the `c` parameter was completely unused. I assume this is what it should be used for. The documentation is copied from the PARI code. I don't think there's a way to actually test it, but there is already code in the docstring that tries to pass $c ≠ 1$. The documentation update is invisible because of sagemath#38480 . ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. (not aware of one) - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#38482 Reported by: user202729 Reviewer(s): Frédéric Chapoton
Previously the
cparameter was completely unused. I assume this is what it should be used for.The documentation is copied from the PARI code.
I don't think there's a way to actually test it, but there is already code in the docstring that tries to pass$c ≠ 1$ .
The documentation update is invisible because of #38480 .
📝 Checklist